Fixed issue, where changing DPI scaling on monitor would detach visual elements from toolbar and not reattach/rebuild

CHANGELOG.md

@@ -2,6 +2,18 @@
 All notable changes to this project will be documented in this file.
 
 
+## [1.11.4] - 2025-09-21
+
+### Fixed
+- Fixed issue, where changing DPI scaling on monitor would detach visual elements from toolbar and not reattach/rebuild
+
+
+## [1.11.3] - 2025-05-11
+
+### Changed
+- Changed type lookup to use TypeCache, instead of iterating through all assemblies
+
+
 ## [1.11.2] - 2024-11-26
 
 ### Added

Editor/Toolbar/ToolbarDrawer.cs

@@ -23,7 +23,7 @@ namespace Module.NavigationTool.Editor.Toolbar
             EditorApplication.update -= OnEditorUpdate;
             EditorApplication.update += OnEditorUpdate;
         }
-        
+
         private static void OnEditorUpdate()
         {
             if (!IS_INITIALIZED)
@@ -47,8 +47,8 @@ namespace Module.NavigationTool.Editor.Toolbar
                     DRAWERS[i].Update();
             }
         }
-
-        #if UNITY_2021_1_OR_NEWER
+        
+#if UNITY_2021_1_OR_NEWER
         private static void OnUpdateElements(VisualElement leftAlign, VisualElement rightAlign)
         {
             const float HEIGHT = 22.0f;

Editor/Toolbar/Utilities/ToolbarSettingsUtility.cs

@@ -1,8 +1,13 @@
 using System;
 using System.Collections.Generic;
-using System.Reflection;
 using System.Runtime.Serialization;
 
+#if UNITY_2021_3 || UNITY_2022_2 || UNITY_6000_0_OR_NEWER
+using UnityEditor;
+#else
+using System.Reflection;
+#endif
+
 namespace Module.NavigationTool.Editor.Toolbar
 {
     internal static class ToolbarSettingsUtility
@@ -13,6 +18,21 @@ namespace Module.NavigationTool.Editor.Toolbar
 
             try
             {
+#if UNITY_2021_3 || UNITY_2022_2 || UNITY_6000_0_OR_NEWER
+                var types = TypeCache.GetTypesDerivedFrom<IToolbarSettings>();
+                
+                for (var i = 0; i < types.Count; i++)
+                {
+                    Type type = types[i];
+
+                    if (type.IsInterface || type.IsAbstract)
+                        continue;
+
+                    var toolbar = (IToolbarSettings)FormatterServices.GetUninitializedObject(type);
+                    toolbar.Initialize();
+                    list.Add(toolbar);
+                }
+#else
                 Assembly[] assemblies = AppDomain.CurrentDomain.GetAssemblies();
                 Type iType = typeof(IToolbarSettings);
                 
@@ -33,6 +53,7 @@ namespace Module.NavigationTool.Editor.Toolbar
                         list.Add(toolbar);
                     }
                 }
+#endif
                 
                 list.Sort((s0, s1) => string.Compare(s0.Title, s1.Title, StringComparison.Ordinal));
             }
@@ -50,6 +71,21 @@ namespace Module.NavigationTool.Editor.Toolbar
 
             try
             {
+#if UNITY_2021_3 || UNITY_2022_2 || UNITY_6000_0_OR_NEWER
+                var types = TypeCache.GetTypesDerivedFrom<IToolbarProjectSettings>();
+                
+                for (var i = 0; i < types.Count; i++)
+                {
+                    Type type = types[i];
+
+                    if (type.IsInterface || type.IsAbstract)
+                        continue;
+
+                    var toolbar = (IToolbarProjectSettings)FormatterServices.GetUninitializedObject(type);
+                    toolbar.Initialize(settings);
+                    list.Add(toolbar);
+                }
+#else
                 Assembly[] assemblies = AppDomain.CurrentDomain.GetAssemblies();
                 Type iType = typeof(IToolbarProjectSettings);
                 
@@ -70,6 +106,7 @@ namespace Module.NavigationTool.Editor.Toolbar
                         list.Add(toolbar);
                     }
                 }
+#endif
                 
                 list.Sort((s0, s1) => string.Compare(s0.Title, s1.Title, StringComparison.Ordinal));
             }

Editor/Toolbar/Utilities/ToolbarUtility.cs

@@ -5,6 +5,10 @@ using System.Reflection;
 using System.Runtime.Serialization;
 using Object = UnityEngine.Object;
 
+#if UNITY_2021_3 || UNITY_2022_2 || UNITY_6000_0_OR_NEWER
+using UnityEditor;
+#endif
+
 #if UNITY_2019_1_OR_NEWER
 using UnityEngine.UIElements;
 #else
@@ -17,25 +21,27 @@ namespace Module.NavigationTool.Editor.Toolbar
     {
         private static readonly Assembly ASSEMBLY = typeof(UnityEditor.Editor).Assembly;
         
-        #if UNITY_2021_1_OR_NEWER
+#if UNITY_2021_1_OR_NEWER
         private static ScriptableObject CURRENT_TOOLBAR;
+        private static VisualElement CURRENT_ROOT;
         private static VisualElement CURRENT_PARENT_LEFT;
         private static VisualElement CURRENT_PARENT_RIGHT;
-        private static int CURRENT_INSTANCE_ID = -1;
-        #endif
+        private static int CURRENT_INSTANCE_ID;
+        private static FieldInfo FIELD_INFO_ROOT;
+#endif
         
-        #if UNITY_2021_1_OR_NEWER
+#if UNITY_2021_1_OR_NEWER
         public static void OnUpdate(Action<VisualElement, VisualElement> callback)
         {
             if (CURRENT_TOOLBAR == null)
                 CURRENT_TOOLBAR = GetToolbarObject();
             
-            if (CURRENT_TOOLBAR != null && CURRENT_PARENT_LEFT != null && CURRENT_TOOLBAR.GetInstanceID() != CURRENT_INSTANCE_ID)
+            if (CURRENT_TOOLBAR != null && CURRENT_TOOLBAR.GetInstanceID() != CURRENT_INSTANCE_ID)
             {
-                CURRENT_PARENT_LEFT.RemoveFromHierarchy();
+                CURRENT_PARENT_LEFT?.RemoveFromHierarchy();
                 CURRENT_PARENT_LEFT = null;
                 
-                CURRENT_PARENT_RIGHT.RemoveFromHierarchy();
+                CURRENT_PARENT_RIGHT?.RemoveFromHierarchy();
                 CURRENT_PARENT_RIGHT = null;
                 
                 CURRENT_INSTANCE_ID = CURRENT_TOOLBAR.GetInstanceID();
@@ -44,17 +50,27 @@ namespace Module.NavigationTool.Editor.Toolbar
             if (CURRENT_TOOLBAR == null)
                 return;
 
-            if (CURRENT_PARENT_LEFT == null)
+            if (CURRENT_PARENT_LEFT == null || CURRENT_PARENT_RIGHT == null || CURRENT_ROOT == null)
             {
+                CURRENT_INSTANCE_ID = CURRENT_TOOLBAR.GetInstanceID();
+                
                 CURRENT_PARENT_LEFT?.RemoveFromHierarchy();
+                CURRENT_PARENT_LEFT = null;
+                
                 CURRENT_PARENT_RIGHT?.RemoveFromHierarchy();
+                CURRENT_PARENT_RIGHT = null;
 
-                FieldInfo root = CURRENT_TOOLBAR.GetType().GetField("m_Root", BindingFlags.NonPublic | BindingFlags.Instance);
-                object rawRoot = root?.GetValue(CURRENT_TOOLBAR);
-                var mRoot = rawRoot as VisualElement;
-            
-                CURRENT_PARENT_LEFT = CreateParent(mRoot, "ToolbarZoneLeftAlign", true);
-                CURRENT_PARENT_RIGHT = CreateParent(mRoot, "ToolbarZoneRightAlign", false);
+                if (FIELD_INFO_ROOT == null)
+                    FIELD_INFO_ROOT = CURRENT_TOOLBAR.GetType().GetField("m_Root", BindingFlags.NonPublic | BindingFlags.Instance);
+                
+                object rawRoot = FIELD_INFO_ROOT?.GetValue(CURRENT_TOOLBAR);
+                CURRENT_ROOT = rawRoot as VisualElement;
+
+                if (CURRENT_ROOT != null)
+                {
+                    CURRENT_PARENT_LEFT = CreateParent(CURRENT_ROOT, "ToolbarZoneLeftAlign", true);
+                    CURRENT_PARENT_RIGHT = CreateParent(CURRENT_ROOT, "ToolbarZoneRightAlign", false);
+                }
             }
             
             if (CURRENT_PARENT_LEFT != null)
@@ -108,10 +124,14 @@ namespace Module.NavigationTool.Editor.Toolbar
                 });
             }
 
+#if UNITY_6000_0_OR_NEWER
+            result.RegisterCallbackOnce<DetachFromPanelEvent>(OnDetachedFromPanel);
+#endif
+            
             parent.Add(result);
             return result;
         }
-        #else
+#else
         public static void AddGuiListener(Action action)
         {
             ScriptableObject so = GetToolbarObject();
@@ -153,7 +173,7 @@ namespace Module.NavigationTool.Editor.Toolbar
             handler += action;
             fiImguiContainer.SetValue(container, handler);
         }
-        #endif
+#endif
 
         private static ScriptableObject GetToolbarObject()
         {
@@ -168,6 +188,17 @@ namespace Module.NavigationTool.Editor.Toolbar
 
             try
             {
+#if UNITY_2021_3 || UNITY_2022_2 || UNITY_6000_0_OR_NEWER
+                var types = TypeCache.GetTypesDerivedFrom<AbstractToolbarDrawer>();
+                
+                for (var i = 0; i < types.Count; i++)
+                {
+                    Type type = types[i];
+
+                    if (!type.IsAbstract)
+                        list.Add((AbstractToolbarDrawer)FormatterServices.GetUninitializedObject(type));
+                }
+#else
                 Assembly[] assemblies = AppDomain.CurrentDomain.GetAssemblies();
                 Type iType = typeof(AbstractToolbarDrawer);
                 
@@ -184,6 +215,7 @@ namespace Module.NavigationTool.Editor.Toolbar
                             list.Add((AbstractToolbarDrawer)FormatterServices.GetUninitializedObject(type));
                     }
                 }
+#endif
                 
                 list.Sort((t0, t1) => t0.Priority.CompareTo(t1.Priority));
             }
@@ -194,5 +226,12 @@ namespace Module.NavigationTool.Editor.Toolbar
 
             return list.ToArray();
         }
+        
+#if UNITY_6000_0_OR_NEWER
+        private static void OnDetachedFromPanel(DetachFromPanelEvent evt)
+        {
+            CURRENT_INSTANCE_ID = -1;
+        }
+#endif
     }
 }

LICENSE

@@ -0,0 +1,9 @@
+MIT License
+
+Copyright (c) 2025 ejlersen
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

LICENSE.meta

@@ -0,0 +1,7 @@
+fileFormatVersion: 2
+guid: 81eaa9f1644b27547b1195ceb554d6b9
+DefaultImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "com.module.navigationtool",
-  "version": "1.11.2",
+  "version": "1.11.4",
   "displayName": "Module.NavigationTool",
   "description": "Support for navigation tools, like favorites, history and toolbars",
   "unity": "2019.2",